Yaniv Bronhaim has posted comments on this change.
Change subject: API: Adding ssh username, port and fingerprint to host
information
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 1811: body:
Line 1812: parameterType: Host
Line 1813: signatures:
Line 1814: - mandatoryArguments: {host.name: 'xs:string', host.address:
'xs:string', host.root_password: 'xs:string', host.cluster.id|name: 'xs:string'}
Line 1815: optionalArguments: {host.ssh.port: 'xs:int',
host.ssh.fingerprint: 'xs:string', host.ssh.username: 'xs:string',ost.port:
'xs:int',
by mistake i deleted the 'h' - host.port is another param.
so username won't appear yet.
Line 1816: host.display.address: 'xs:string',
host.storage_manager.priority: 'xs:int', host.power_management.type:
'xs:string',
Line 1817: host.power_management.enabled: 'xs:boolean',
host.power_management.address: 'xs:string', host.power_management.username:
'xs:string',
Line 1818: host.power_management.password: 'xs:string',
host.power_management.options.option--COLLECTION: {option.name: 'xs:string',
option.value: 'xs:string'}, host.power_management.pm_proxy--COLLECTION:
{propietary : 'xs:string'},
host.power_management.agents.agent--COLLECTION:{type: 'xs:string', address:
'xs:string', user_name: 'xs:string', password: 'xs:string',
options.option--COLLECTION: {option.name: 'xs:string', option.value:
'xs:string'}}, host.reboot_after_installation: 'xs:boolean'}
Line 1819: urlparams: {}
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
Line 52: assertNotNull(transform.getCluster());
Line 53: assertEquals(model.getCluster().getId(),
transform.getCluster().getId());
Line 54: assertEquals(model.getAddress(), transform.getAddress());
Line 55: assertEquals(model.getPort(), transform.getPort());
Line 56: assertEquals(model.getSsh(), transform.getSsh());
you need to show me how .. until then ill compare the content.
Line 57: assertEquals(model.getStorageManager().getPriority(),
transform.getStorageManager().getPriority());
Line 58: assertEquals(model.getDisplay().getAddress(),
transform.getDisplay().getAddress());
Line 59: }
Line 60:
--
To view, visit http://gerrit.ovirt.org/16247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b8c117d041c29780af2468888a732ee664d283c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
