Allon Mureinik has posted comments on this change.
Change subject: core: async task mgr + batch - cleanups
......................................................................
Patch Set 3: (8 inline comments)
I don't get this patch - where are the entities inserted?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
Line 48: AsyncTasks entity = new AsyncTasks();
Line 49:
entity.setaction_type(VdcActionType.forValue(rs.getInt("action_type")));
Line 50:
entity.setresult(AsyncTaskResultEnum.forValue(rs.getInt("result")));
Line 51:
entity.setstatus(AsyncTaskStatusEnum.forValue(rs.getInt("status")));
Line 52:
entity.setTaskId(Guid.createGuidFromStringDefaultEmpty(rs.getString("task_id")));
use getGuid("task_id")
Line 53:
entity.setVdsmTaskId(Guid.createGuidFromString(rs.getString("vdsm_task_id")));
Line 54:
entity.setActionParameters(deserializeParameters(rs.getString("action_parameters"),
Line 55: rs.getString("action_params_class")));
Line 56:
entity.setTaskParameters(deserializeParameters(rs.getString("task_parameters"),
Line 49:
entity.setaction_type(VdcActionType.forValue(rs.getInt("action_type")));
Line 50:
entity.setresult(AsyncTaskResultEnum.forValue(rs.getInt("result")));
Line 51:
entity.setstatus(AsyncTaskStatusEnum.forValue(rs.getInt("status")));
Line 52:
entity.setTaskId(Guid.createGuidFromStringDefaultEmpty(rs.getString("task_id")));
Line 53:
entity.setVdsmTaskId(Guid.createGuidFromString(rs.getString("vdsm_task_id")));
use getGuid("vdsm_task_id")
Line 54:
entity.setActionParameters(deserializeParameters(rs.getString("action_parameters"),
Line 55: rs.getString("action_params_class")));
Line 56:
entity.setTaskParameters(deserializeParameters(rs.getString("task_parameters"),
Line 57: rs.getString("task_params_class")));
Line 54:
entity.setActionParameters(deserializeParameters(rs.getString("action_parameters"),
Line 55: rs.getString("action_params_class")));
Line 56:
entity.setTaskParameters(deserializeParameters(rs.getString("task_parameters"),
Line 57: rs.getString("task_params_class")));
Line 58:
entity.setStepId(Guid.createGuidFromString(rs.getString("step_id")));
use getGuid
Line 59:
entity.setCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("command_id")));
Line 60:
entity.setRootCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("root_command_id")));
Line 61:
entity.setStartTime(DbFacadeUtils.fromDate(rs.getTimestamp("started_at")));
Line 62:
entity.setTaskType(AsyncTaskType.forValue(rs.getInt("task_type")));
Line 55: rs.getString("action_params_class")));
Line 56:
entity.setTaskParameters(deserializeParameters(rs.getString("task_parameters"),
Line 57: rs.getString("task_params_class")));
Line 58:
entity.setStepId(Guid.createGuidFromString(rs.getString("step_id")));
Line 59:
entity.setCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("command_id")));
use getGuid
Line 60:
entity.setRootCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("root_command_id")));
Line 61:
entity.setStartTime(DbFacadeUtils.fromDate(rs.getTimestamp("started_at")));
Line 62:
entity.setTaskType(AsyncTaskType.forValue(rs.getInt("task_type")));
Line 63: entity.setStoragePoolId(getGuidDefaultEmpty(rs,
"storage_pool_id"));
Line 56:
entity.setTaskParameters(deserializeParameters(rs.getString("task_parameters"),
Line 57: rs.getString("task_params_class")));
Line 58:
entity.setStepId(Guid.createGuidFromString(rs.getString("step_id")));
Line 59:
entity.setCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("command_id")));
Line 60:
entity.setRootCommandId(Guid.createGuidFromStringDefaultEmpty(rs.getString("root_command_id")));
use getGuid
Line 61:
entity.setStartTime(DbFacadeUtils.fromDate(rs.getTimestamp("started_at")));
Line 62:
entity.setTaskType(AsyncTaskType.forValue(rs.getInt("task_type")));
Line 63: entity.setStoragePoolId(getGuidDefaultEmpty(rs,
"storage_pool_id"));
Line 64: return entity;
Line 76: }
Line 77:
Line 78: private static class AsyncTaskParameterSource extends
CustomMapSqlParameterSource {
Line 79:
Line 80: public AsyncTaskParameterSource(DbEngineDialect dialect,
AsyncTasks task) {
Formatting change?
If so - this is unrelated to the patch.
Line 81: super(dialect);
Line 82: addValue("action_type", task.getaction_type());
Line 83: addValue("result", task.getresult());
Line 84: addValue("status", task.getstatus());
Line 84: addValue("status", task.getstatus());
Line 85: addValue("vdsm_task_id", task.getVdsmTaskId());
Line 86: addValue("task_id", task.getTaskId());
Line 87: addValue("action_parameters",
serializeParameters(task.getActionParameters()));
Line 88: addValue("action_params_class",
task.getActionParameters().getClass().getName());
Formatting change?
If so - this is unrelated to the patch.
Line 89: addValue("task_parameters",
serializeParameters(task.getTaskParameters()));
Line 90: addValue("task_params_class",
task.getTaskParameters().getClass().getName());
Line 91: addValue("step_id", task.getStepId());
Line 92: addValue("command_id", task.getCommandId());
Line 86: addValue("task_id", task.getTaskId());
Line 87: addValue("action_parameters",
serializeParameters(task.getActionParameters()));
Line 88: addValue("action_params_class",
task.getActionParameters().getClass().getName());
Line 89: addValue("task_parameters",
serializeParameters(task.getTaskParameters()));
Line 90: addValue("task_params_class",
task.getTaskParameters().getClass().getName());
Formatting change?
If so - this is unrelated to the patch.
Line 91: addValue("step_id", task.getStepId());
Line 92: addValue("command_id", task.getCommandId());
Line 93: addValue("root_command_id", task.getRootCommandId());
Line 94: }
--
To view, visit http://gerrit.ovirt.org/16445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6d8dc6095430c99fdb6c8cd8289c23e270fff9e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
