Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing batch to async task mgr
......................................................................
Patch Set 7: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1367
Line 1368
Line 1369
Line 1370
Line 1371
Will do.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTaskEntity.java
Line 32: return true;
Line 33: if (obj == null)
Line 34: return false;
Line 35: if (getClass() != obj.getClass())
Line 36: return false;
Stupid eclipse generation, i will do that.
Line 37:
Line 38: AsyncTaskEntity other = (AsyncTaskEntity) obj;
Line 39: return ObjectUtils.objectsEqual(taskId, other.taskId) &&
Line 40: ObjectUtils.objectsEqual(entityId, other.entityId) &&
Line 72: }
Line 73:
Line 74: @Override
Line 75: public Guid getId() {
Line 76: return taskId;
Correct, if we choose to go for BusinessEntity (which I guess is not really
needed, I'll check that, maybe something to do with the batch support) - I
should have a different ID - for example like in StoragePoolIsoMap
Line 77: }
Line 78:
Line 79: @Override
Line 80: public void setId(Guid id) {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
Line 51: public AsyncTaskEntity mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 52: AsyncTaskEntity entity = new AsyncTaskEntity();
Line 53: entity.setEntityId(getGuid(rs, "entity_id"));
Line 54: entity.setTaskId(getGuid(rs, "async_task_id"));
Line 55:
entity.setEntityType(VdcObjectType.valueOf(rs.getString("entity_type")));
I explained in the abandoned patch - if you look at how save() looks before
this patch you will see "entity_type" is being passed the same way (i.e -
translated to string) - the entity_type definition in async_tasks_entities
table is of varchar.
We did that for readability.
If you want it to get changed, IMHO should be in different patch.
Line 56: return entity;
Line 57: }
Line 58: }
Line 59:
--
To view, visit http://gerrit.ovirt.org/16445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6d8dc6095430c99fdb6c8cd8289c23e270fff9e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
