Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to Storage [5]
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
Line 120: }
Line 121: };
Line 122: getTable().addColumn(descriptionColumn,
constants.domainDescriptionStorage(), "200px"); //$NON-NLS-1$
Line 123:
Line 124: getTable().addColumn(new CommentColumn<StorageDomain>(),
constants.commentLabel(), "100px"); //$NON-NLS-1$
please verify later on that the column's width is identical on every main tab.
Line 125:
Line 126: getTable().addActionButton(new
WebAdminButtonDefinition<StorageDomain>(constants.newDomainStorage()) {
Line 127: @Override
Line 128: protected UICommand resolveCommand() {
--
To view, visit http://gerrit.ovirt.org/15486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fd8a1b83ed330c945025f13abf565fd899563e7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
