Daniel Erez has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReinitializeSPMParameters.java
Line 6:
Line 7: private Guid preferredSPMId;
Line 8: private Guid storagePoolId = Guid.Empty;
Line 9:
Line 10: public ReinitializeSPMParameters(Guid storagePoolId, Guid
prefferedSPMId) {
default ctr is probably needed for gwt-rpc serialization
Line 11: setStoragePoolId(storagePoolId);
Line 12: setPreferredSPMId(prefferedSPMId);
Line 13: }
Line 14:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 278: GLUSTER_SERVICE_RESTARTED(4072),
Line 279: GLUSTER_SERVICE_RESTART_FAILED(4073),
Line 280: GLUSTER_VOLUME_OPTIONS_RESET_ALL(4074),
Line 281:
Line 282: USER_REINITIALIZED_SPM(159),
add to .properties file as well
Line 283: USER_VDS_RESTART(41),
Line 284: USER_FAILED_VDS_RESTART(107),
Line 285: USER_VDS_START(20),
Line 286: USER_FAILED_VDS_START(118),
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 1822:
Line 1823: }
Line 1824:
Line 1825: private boolean isSetAsSpmCommandAllowed(List<VDS>
selectedItems) {
Line 1826: if (selectedItems.size() != 1)
add curly braces
Line 1827: return false;
Line 1828:
Line 1829: VDS vds = selectedItems.get(0);
Line 1830:
--
To view, visit http://gerrit.ovirt.org/16105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab31fc7918b10448b923821547a583f3d6c3fcba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
