A Burden has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 4: (2 inline comments)
'Never' (in the SPM error) should be represented as such, as it is a UI element.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 80: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 81: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 82: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host
${VdsName} is not active.
Line 83: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.
Line 84: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The SPM priority of Host ${VdsName} is set to never. This Host cannot be
elected as SPM.
Agreed.
Suggest to rewrite as "Cannot ${action} ${type}. The SPM priority of Host
${VdsNa
me} is set to 'Never'. This Host cannot be elected as SPM.
Line 85: CANNOT_REINIT_SPM_STORAGE_POOL_HAS_RUNNING_TASKS=Cannot ${action}
${type}. The Storage Pool has running tasks.
Line 86: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 87: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 88: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 80: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 81: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 82: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host
${VdsName} is not active.
Line 83: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.
Line 84: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The SPM priority of Host ${VdsName} is set to never. This Host cannot be
elected as SPM.
Suggest to rewrite as "Cannot ${action} ${type}. The SPM priority of Host
${VdsNa
me} is set to 'Never'. This Host cannot be elected as SPM.
Line 85: CANNOT_REINIT_SPM_STORAGE_POOL_HAS_RUNNING_TASKS=Cannot ${action}
${type}. The Storage Pool has running tasks.
Line 86: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 87: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 88: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
--
To view, visit http://gerrit.ovirt.org/16105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab31fc7918b10448b923821547a583f3d6c3fcba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
