Martin Peřina has posted comments on this change.
Change subject: code: host-deploy: Adding ssh_username and ssh_port to VDS
object - VdsStatic fields
......................................................................
Patch Set 19: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 1: package org.ovirt.engine.core.bll;
Line 2:
Line 3: import java.io.ByteArrayOutputStream;
Line 4:
Line 5: import org.ovirt.engine.core.bll.utils.EngineSSHClient;
import org.ovirt.engine.core.utils.ssh.EngineSSHClient;
Line 6: import org.ovirt.engine.core.common.action.VdsActionParameters;
Line 7: import org.ovirt.engine.core.common.config.Config;
Line 8: import org.ovirt.engine.core.common.config.ConfigValues;
Line 9: import org.ovirt.engine.core.vdsbroker.ResourceManager;
Line 69: EngineSSHClient sshClient = null;
Line 70:
Line 71: try {
Line 72: sshClient = new EngineSSHClient();
Line 73: sshClient.setVds(getVds());
There is no such method in EngineSSHClient yet. Are you going to add it or is
it part of some other patch?
Line 74: sshClient.useDefaultKeyPair();
Line 75: sshClient.connect();
Line 76: sshClient.authenticate();
Line 77: ByteArrayOutputStream bos = new ByteArrayOutputStream();
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
Line 72: .addValue("ip", vds.getManagementIp())
Line 73: .addValue("vds_unique_id", vds.getUniqueID())
Line 74: .addValue("port", vds.getPort())
Line 75: .addValue("ssh_port", vds.getSSHPort())
Line 76: .addValue("ssh_username", vds.getSSHUsername())
You forgot to remove execution of old methods, execution of new methods is
below.
Line 77: .addValue("vds_group_id", vds.getVdsGroupId())
Line 78: .addValue("vds_id", vds.getId())
Line 79: .addValue("vds_name", vds.getName())
Line 80: .addValue("server_SSL_enabled",
vds.isServerSslEnabled())
--
To view, visit http://gerrit.ovirt.org/16096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
