Alon Bar-Lev has posted comments on this change.
Change subject: code: host-deploy: Adding ssh_username and ssh_port to VDS
object - VdsStatic fields
......................................................................
Patch Set 21: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 391: if (unique) {
Line 392: String old_host_name =
vds_byHostName.getHostName();
Line 393: vds_byHostName.setHostName(try_host_name);
Line 394: UpdateVdsActionParameters parameters = new
UpdateVdsActionParameters(
Line 395: vds_byHostName.getStaticData(), "" ,
false);
there was no need for this change.
Line 396: parameters.setShouldBeLogged(false);
Line 397:
parameters.setTransactionScopeOption(TransactionScopeOption.RequiresNew);
Line 398: VdcReturnValueBase ret =
Backend.getInstance().runInternalAction(VdcActionType.UpdateVds, parameters);
Line 399:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 1315: return mVdsStatic.getSshKeyFingerprint();
Line 1316: }
Line 1317:
Line 1318: public void setSshKeyFingerprint(String sshKeyFingerprint) {
Line 1319: mVdsStatic.setSshKeyFingerprint(sshKeyFingerprint);
well, I prefer SSH and not force the java conventions over the real world...
but cannot fight with stronger forces.
Line 1320: }
Line 1321:
Line 1322: private float maxSchedulingMemory;
Line 1323:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
Line 827: host.setHostName(hostDetailModel.getAddress());
Line 828:
host.setSshKeyFingerprint(hostDetailModel.getFingerprint());
Line 829: host.setPort(54321);
Line 830:
Line 831:
host.setVdsGroupId(hostsModel.getClusterModel().getClusterId());
this change is not part of this patch.
Line 832: host.setpm_enabled(false);
Line 833:
Line 834: AddVdsActionParameters parameters = new
AddVdsActionParameters();
Line 835: parameters.setVdsId(host.getId());
--
To view, visit http://gerrit.ovirt.org/16096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
