Michal Skrivanek has posted comments on this change. Change subject: core: Add new OSs to engine ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File packaging/conf/osinfo-defaults.properties Line 51: Line 52: os.linux.id.value = 100 Line 53: os.linux.name.value = Linux Line 54: os.linux.derivedFrom.value = Other Line 55: os.linux.description.value = General GNU/Linux not that it's related, but why do I have audio ac97 here in Other and in Windows as well? Line 56: os.linux.family.value = linux Line 57: os.linux.devices.audio.value = ac97 Line 58: Line 59: Line 205: #Suse Line 206: os.sles11.id.value = 1193 Line 207: os.sles11.name.value = Suse Linux Enterprise Server 11 Line 208: os.sles11.family.value = linux Line 209: os.sles11.derivedFrom = Other is it correct, shouldn't it be based on general Linux? currently only the audio hw differ - are we using ac97 rhel&fedora&windows and with with suse&ubuntu and we use ich6? Line 210: Line 211: #Ubuntu Line 212: os.ubuntu12_04.id.value = 1252 Line 213: os.ubuntu12_04.name.value = Ubuntu Precise Pangolin LTS -- To view, visit http://gerrit.ovirt.org/16680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaec676a465c64fae96564fcd9f9aa24d132d6b96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
