Michal Skrivanek has posted comments on this change. Change subject: core: Add new OSs to engine ......................................................................
Patch Set 8: (3 inline comments) .................................................... File packaging/conf/osinfo-defaults.properties Line 203: os.other_linux.derivedFrom.value = linux Line 204: Line 205: #Suse Line 206: os.sles_11.id.value = 1193 Line 207: os.sles_11.name.value = Suse Linux Enterprise Server 11 should be SUSE Line 208: os.sles_11.family.value = linux Line 209: os.sles_11.derivedFrom.value = linux Line 210: Line 211: #Ubuntu Line 204: Line 205: #Suse Line 206: os.sles_11.id.value = 1193 Line 207: os.sles_11.name.value = Suse Linux Enterprise Server 11 Line 208: os.sles_11.family.value = linux do I have to copy family all the time when there is derivedFrom? Line 209: os.sles_11.derivedFrom.value = linux Line 210: Line 211: #Ubuntu Line 212: os.ubuntu_12_04.id.value = 1252 Line 219: Line 220: os.ubuntu_12_10.id.value = 1253 Line 221: os.ubuntu_12_10.name.value = Ubuntu Quantal Quetzal Line 222: os.ubuntu_12_10.family.value = linux Line 223: os.ubuntu_12_10.derivedFrom.value = linux how about just deriving from the first Ubuntu, since all params are the same? Line 224: os.ubuntu_12_10.resources.minimum.ram.value = 1024 Line 225: os.ubuntu_12_10.resources.minimum.disksize.value = 5120 Line 226: os.ubuntu_12_10.resources.minimum.numberOsCpus.value = 1 Line 227: -- To view, visit http://gerrit.ovirt.org/16680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaec676a465c64fae96564fcd9f9aa24d132d6b96 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
