Arik Hadas has posted comments on this change.
Change subject: core: remove snapshot's memory on remove vm from export domain
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
Line 17: }
Line 18:
Line 19: @Override
Line 20: protected boolean isPostZero() {
Line 21: return false;
see UIConstants#wipeAfterDeleteNotSupportedForFileDomains message that is
raised by the UI. the guys that work on the storage also say that it doesn't
makes sense to them to set it when removing from export domain because NFS is
makes the wiping on its own. you're right that in the backend we always set
wipe after delete if one of the disks is set that way, so in order to be
consistent with the rest of the code, I'll do the same - there should be no
overhead of performance if NFS doesn't support it, there will just be code
which is currently redundant so I'll add a comment to explain it.
Line 22: }
Line 23:
Line 24: @Override
Line 25: protected boolean shouldRemoveMemorySnapshotVolumes(String
memoryVolume) {
--
To view, visit http://gerrit.ovirt.org/16711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf0f29aade5cb7c93949a27067d7c4270e86032
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
