Arik Hadas has posted comments on this change.
Change subject: core: remove snapshot's memory on remove vm from export domain
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
Line 17: }
Line 18:
Line 19: @Override
Line 20: protected boolean isPostZero() {
Line 21: return false;
I see that the "wipe after delete" option is enabled only for block based
storage so I guess it has no meaning for file based storage right? if so, since
the export domain is always on file based storage, the post zero can remain
false in this command
Line 22: }
Line 23:
Line 24: @Override
Line 25: protected boolean shouldRemoveMemorySnapshotVolumes(String
memoryVolume) {
--
To view, visit http://gerrit.ovirt.org/16711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf0f29aade5cb7c93949a27067d7c4270e86032
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
