Ravi Nori has posted comments on this change.
Change subject: core: Fix race between AsyncTaskManager and VdsManager
......................................................................
Patch Set 1: (1 inline comment)
Minor comment on finally block
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 210: boolean isPartiallySubmittedCommand =
isPartiallySubmittedCommand(tasks);
Line 211: for (AsyncTasks task : tasks) {
Line 212:
handleTaskOfCommandWithEmptyVdsmId(isPartiallySubmittedCommand, task);
Line 213: }
Line 214: irsBrokerLatch.countDown();
I think it is better to do this in the finally block, just in case an exception
is thrown in the previous methods.
Line 215: return null;
Line 216: }
Line 217: });
Line 218: }
--
To view, visit http://gerrit.ovirt.org/16821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbbacef1109741ef005e33d1e4c7f4f7cc741338
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
