Ravi Nori has posted comments on this change.
Change subject: core: Add the ability to create a dummy task in case of VDSM
failure
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment on using Guid.isNullOrEmpty
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java
Line 55: java.util.ArrayList<CommandAsyncTask>
CurrentActionTypeTasks = getCurrentTasks();
Line 56:
Line 57: for (CommandAsyncTask task : CurrentActionTypeTasks) {
Line 58: // Check this is a task that is run on VDSM and is not
in ENDED state.
Line 59: if (task.getState() != AsyncTaskState.Ended &&
!task.getVdsmTaskId().equals(Guid.Empty)) {
I think it is better to use Guid.isNullOrEmpty instead, so the above check can
be
!Guid.isNullOrEmpty(task.getVdsmTaskId())
Line 60: log.infoFormat("Task ID: '{0}' is in state {1}.
End action for command {2} will proceed when all the entity's tasks are
completed.",
Line 61: task.getVdsmTaskId(),
Line 62: task.getState(),
Line 63: getCommandId());
--
To view, visit http://gerrit.ovirt.org/16642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
