Maor Lipchuk has posted comments on this change.
Change subject: core: Add the ability to create a dummy task in case of VDSM
failure
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 785: }
Line 786:
Line 787: return false;
Line 788: }
Line 789:
suggestion: I would put this method before
logAndFailTaskOfCommandWithEmptyVdsmId(AsyncTask...
Line 790: public static void logAndFailTaskOfCommandWithEmptyVdsmId(Guid
asyncTaskId, String message) {
Line 791: AsyncTasks task =
DbFacade.getInstance().getAsyncTaskDao().get(asyncTaskId);
Line 792: logAndFailTaskOfCommandWithEmptyVdsmId(task, message);
Line 793: }
--
To view, visit http://gerrit.ovirt.org/16642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
