Sandro Bonazzola has posted comments on this change. Change subject: network: firewalld: allow disabling services ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) I'm investigating an issue I've seen on a fresh install, I'm preparing a new patchset. .................................................... File src/plugins/otopi/network/firewalld.py Line 120: ) Line 121: zones = [] Line 122: for line in stdout: Line 123: zones += line.split() Line 124: return zones Done Line 125: Line 126: def __init__(self, context): Line 127: super(Plugin, self).__init__(context=context) Line 128: self._enabled = os.geteuid() == 0 -- To view, visit http://gerrit.ovirt.org/17026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75418f4c7d90f8119c8259d0a33ed9fdfa69c91d Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
