Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: allow disabling services
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 220: state=True,
Line 221: )
Line 222: self.services.startup(name='firewalld', state=True)
Line 223:
Line 224: #Disabling existing services before configuration reload
I think that pep8 does not accept #xxx but # xxx
Anyway, I usually like two type of comments..
#
# block comment usually long comment
# for logic
#
print('hello world!') # line comment
Anyway... can you please explain more in the comment, why is it before reload?
I guess that reload will fail because of these missing service files.
Thanks!
Line 225: for zone in self._get_zones():
Line 226: for service in self.environment[
Line 227: constants.NetEnv.FIREWALLD_DISBALE_SERVICES
Line 228: ]:
--
To view, visit http://gerrit.ovirt.org/17026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75418f4c7d90f8119c8259d0a33ed9fdfa69c91d
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
