Doron Fediuck has posted comments on this change.
Change subject: engine: Report when vm gets less the Guaranteed memory
......................................................................
Patch Set 4: (1 inline comment)
Still an issue needs resolving to prevent false alarms.
See inline for details.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1308: for (VmInternalData vmInternalData : _runningVms.values()) {
Line 1309: VM savedVm =
_vmDict.get(vmInternalData.getVmDynamic().getId());
Line 1310: VmStatistics vmStatistics =
vmInternalData.getVmStatistics();
Line 1311: if (vmStatistics.getCurrentMemory() != null &&
Line 1312: savedVm.getMinAllocatedMem() >
vmStatistics.getCurrentMemory()) {
getCurrentMemory may return 0 or null if no balloon device,
in which case you'll trigger a redundant alert.
Please check first if getCurrentMemory > 0 and only then if it's below the
guaranteed.
Thanks.
Line 1313: AuditLogableBase auditLogable = new
AuditLogableBase();
Line 1314: auditLogable.addCustomValue("VmName",
savedVm.getName());
Line 1315: auditLogable.addCustomValue("VdsName",
this._vds.getName());
Line 1316: auditLogable.addCustomValue("MemGuaranteed",
String.valueOf(savedVm.getMinAllocatedMem()));
--
To view, visit http://gerrit.ovirt.org/16949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
