Allon Mureinik has posted comments on this change.

Change subject: core, restapi: Introducing ImportVmFromConfigurationCommand
......................................................................


Patch Set 9: Looks good to me, but someone else must approve

(1 inline comment)

+1 on the backend part, pending REST review.

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 202:               <include name="common/businessentities/VdcRole.java" />
Line 203: 
Line 204:               <include 
name="common/businessentities/FenceActionType.java" />
Line 205:               <include 
name="common/businessentities/CopyVolumeType.java" />
Line 206:         <include 
name="common/businessentities/ConfigurationType.java" />
alignment still seems off
Line 207:               <include 
name="common/businessentities/ImageOperation.java" />
Line 208:               <include 
name="common/businessentities/ImageDbOperationScope.java" />
Line 209:               <include name="common/businessentities/VdcOption.java" 
/>
Line 210:               <include name="common/errors/VdcFault.java" />


-- 
To view, visit http://gerrit.ovirt.org/15894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to