Allon Mureinik has posted comments on this change.
Change subject: core: Add storage validation when plugging an image.
......................................................................
Patch Set 6: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 53: }
Line 54:
Line 55: private boolean imageStorageValidation() {
Line 56: // If the VM is not an image then it does not use the storage
domain.
Line 57: // If the VM is not in UP or PAUSED status, then we knwo that
there is no running qemu process,
s/knwo/know/
Line 58: // so we don't need to check the storage domain activity.
Line 59: if (disk.getDiskStorageType() != DiskStorageType.IMAGE
Line 60: || (getVm().getStatus() != VMStatus.Up &&
getVm().getStatus() != VMStatus.Paused)) {
Line 61: return true;
Line 56: // If the VM is not an image then it does not use the storage
domain.
Line 57: // If the VM is not in UP or PAUSED status, then we knwo that
there is no running qemu process,
Line 58: // so we don't need to check the storage domain activity.
Line 59: if (disk.getDiskStorageType() != DiskStorageType.IMAGE
Line 60: || (getVm().getStatus() != VMStatus.Up &&
getVm().getStatus() != VMStatus.Paused)) {
use !getVm().getStatus().isRunningOrPaused()
Line 61: return true;
Line 62: }
Line 63: DiskImage diskImage = (DiskImage) disk;
Line 64: StorageDomain storageDomain =
getStorageDomainDAO().getForStoragePool(
....................................................
Commit Message
Line 5: CommitDate: 2013-07-29 12:23:17 +0300
Line 6:
Line 7: core: Add storage validation when plugging an image.
Line 8:
Line 9: When a plugging a disk to a VM, the engine should validate if the
storage
s/if/that/
Line 10: domain of the disk is active.
Line 11: There is no reason to call VDSM if it can't connect to the storage.
Line 12:
Line 13: The validation should be done on plug disk, and also on its derived
Line 6:
Line 7: core: Add storage validation when plugging an image.
Line 8:
Line 9: When a plugging a disk to a VM, the engine should validate if the
storage
Line 10: domain of the disk is active.
s/of the disk/that the disk resides on/
Line 11: There is no reason to call VDSM if it can't connect to the storage.
Line 12:
Line 13: The validation should be done on plug disk, and also on its derived
Line 14: operation attachDisk.
--
To view, visit http://gerrit.ovirt.org/17170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
