Arik Hadas has posted comments on this change.
Change subject: core: added is_run_once flag to vm_dynamic
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 59: @Override
Line 60: protected CreateVmVDSCommandParameters initCreateVmParams() {
Line 61: CreateVmVDSCommandParameters createVmParams =
super.initCreateVmParams();
Line 62:
Line 63: getVm().setRunOnce(true);
I meant createVmParams.getVm() of course.. it would work either way because
both ways points to the same object, but it would be more clear when we read
this (I guessed that's what you were intended to do when you moved it)
Line 64: RunVmOnceParams runOnceParams = getParameters();
Line 65:
Line 66: SysPrepParams sysPrepParams = new SysPrepParams();
Line 67:
sysPrepParams.setSysPrepDomainName(runOnceParams.getSysPrepDomainName());
--
To view, visit http://gerrit.ovirt.org/17481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25acdbcc84d326c694d7ae5ff1facaf13e5d683e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
