Arik Hadas has posted comments on this change.
Change subject: core: added is_run_once flag to vm_dynamic
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
Line 42: command.execute();
Line 43: if (command.getVDSReturnValue().getSucceeded()) {
Line 44: vm.setInitialized(true);
Line 45: saveSetInitializedToDb(vm.getId());
Line 46:
DbFacade.getInstance().getVmDao().saveIsRunOnce(vm.getId(), vm.isRunOnce());
yeah I understand why you did it separately and not in
DbFacade.getInstance().getVmDynamicDao().update - you're right. but I didn't
mean to use that method, I meant something else: to call another 'update'
method that will be added which will save the given VM info, including the
run_once property, to the DB. it will be different than the one which is used
by VdsRuntimeInfo that shouldn't save the run_once fiels as you mentioned. it
will reduce the number of times we access the DB in this method
Line 47:
Line 48:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 49: new TransactionMethod<Object>() {
Line 50: @Override
--
To view, visit http://gerrit.ovirt.org/17481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25acdbcc84d326c694d7ae5ff1facaf13e5d683e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
