Sandro Bonazzola has posted comments on this change. Change subject: WIP: packaging: setup: host rename ......................................................................
Patch Set 5: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/pki.py Line 101: osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_STORE, Line 102: osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_KEY, Line 103: osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_CERT, Line 104: ) Line 105: ) I meant all of them Line 106: Line 107: @plugin.event( Line 108: stage=plugin.Stages.STAGE_VALIDATION, Line 109: condition=lambda self: self._enabled, .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py Line 33: Line 34: Line 35: from ovirt_engine_setup import constants as osetupcons Line 36: from ovirt_engine_setup import dialog Line 37: Well, they will be identical if everything goes well. If something goes wrong the CHECK_MODIFIED_FILES is filled, MODIFIED_FILES may be empty or partially filled by local transactions. Line 38: Line 39: @util.export Line 40: class Plugin(plugin.PluginBase): Line 41: """Simple plugin.""" -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
