Yedidyah Bar David has posted comments on this change.
Change subject: WIP: packaging: setup: host rename
......................................................................
Patch Set 5: No score
(4 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/pki.py
Line 101:
osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_STORE,
Line 102: osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_KEY,
Line 103: osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_CERT,
Line 104: )
Line 105: )
Which ones? If you refer to OVIRT_ENGINE_PKI_APACHE_*, they are modified by
OVIRT_ENGINE_PKI_CA_ENROLL later.
If you mean all of them, I reply in another comment
Line 106:
Line 107: @plugin.event(
Line 108: stage=plugin.Stages.STAGE_VALIDATION,
Line 109: condition=lambda self: self._enabled,
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/protocols.py
Line 81: self.environment[
Line 82: osetupcons.ConfigEnv.HTTPS_PORT
Line 83: ] = self.environment[
Line 84: osetupcons.ConfigEnv.JBOSS_HTTPS_PORT
Line 85: ]
I'll check this out.
Line 86: self.environment[
Line 87: otopicons.CoreEnv.MODIFIED_FILES
Line 88: ].append(
Line 89: osetupcons.FileLocations.
Line 182:
Line 183: if self.environment[osetupcons.CoreEnv.DEVELOPER_MODE]:
Line 184: self.dialog.note(
Line 185: text=_(
Line 186: 'JBoss is listending for debug connection at:
{address}'
Done
Line 187: ).format(
Line 188: address=self.environment[
Line 189: osetupcons.ConfigEnv.JBOSS_DEBUG_ADDRESS
Line 190: ],
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py
Line 33:
Line 34:
Line 35: from ovirt_engine_setup import constants as osetupcons
Line 36: from ovirt_engine_setup import dialog
Line 37:
OK, I'll do it this way.
As far as I understand, this means another partial duplication, as these lists
are supposed to be identical eventually. Whatever.
Line 38:
Line 39: @util.export
Line 40: class Plugin(plugin.PluginBase):
Line 41: """Simple plugin."""
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
