Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add backup and restore utility
......................................................................
Patch Set 19: (3 inline comments)
....................................................
File packaging/bin/engine-backup.sh
Line 23: BACKUP_FOLDERS="/etc/ovirt-engine
Line 24: /etc/pki/ovirt-engine
Line 25: /etc/ovirt-engine-setup.conf.d
Line 26: /var/lib/ovirt-engine"
Line 27: VERSION_FILE="/usr/share/ovirt-engine/conf/version"
No... put the following in prolog:
PACKAGE_NAME="@PACKAGE_NAME@"
PACKAGE_VERSION="@PACKAGE_VERSION@"
DISPLAY_VERSION="@DISPLAY_VERSION@"
And you have correct settings without using this version file.
Line 28: MYPGPASS=""
Line 29: TEMP_FOLDER=""
Line 30: FILE=""
Line 31: DB_BACKUP_FILE_NAME="engine_backup.db"
Line 79: --file=*)
Line 80: FILE="${v}"
Line 81: ;;
Line 82: --backup=*)
Line 83: BACKUP_FILE="${v}"
I am very sorry... I do not understand... what is "backing up directories we
override"?
Line 84: ;;
Line 85: --log=*)
Line 86: LOG="${v}"
Line 87: ;;
Line 248: __EOF__
Line 249: }
Line 250:
Line 251: output() {
Line 252: echo "$1"
well, more important is to have better logging than reuse...
I recommend something like:
log() {
local m="$1"
# write ${m} with date timestamp pid etc...
}
logdie() {
local m="$1"
log "FATAL: ${m}"
die "${m}"
}
output() {
local m="$1"
log "${m}"
echo "${m}"
}
Line 253: }
Line 254:
Line 255: ## Main
Line 256:
--
To view, visit http://gerrit.ovirt.org/15276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6c386a0f48ccd520978193639120999e00cf2a
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
