Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add backup and restore utility
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File packaging/bin/engine-backup.sh
Line 79: --file=*)
Line 80: FILE="${v}"
Line 81: ;;
Line 82: --backup=*)
Line 83: BACKUP_FILE="${v}"
oh!!!!!!!!! so you are backing up current state? why not back up database as
well? :)
If I understand correctly, this is just execution of backup before restore...
right? If so, why not trust the guy out there? anyway, as I was confused so
will be the user... what about --infile, --outfile? or just rename the
directory?
Line 84: ;;
Line 85: --log=*)
Line 86: LOG="${v}"
Line 87: ;;
--
To view, visit http://gerrit.ovirt.org/15276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6c386a0f48ccd520978193639120999e00cf2a
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
