Alon Bar-Lev has posted comments on this change.
Change subject: ovirt-live: migrate ovirt live plugin to otopi
......................................................................
Patch Set 4:
(3 comments)
Quick review, I will get back later.
....................................................
File
fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
Line 184: os = params.OperatingSystem(
Line 185: type_='unassigned',
Line 186: boot=[
Line 187: params.Boot(dev='cdrom'),
Line 188: params.Boot(dev='hd')
always put comma at end of lists, tuples.
BTW: are you sure these parameters must be lists and not tuples? tuples are
better in this usage.
Line 189: ]
Line 190: )
Line 191:
Line 192: # Create VM
Line 194: params.VM(
Line 195: name='local_vm',
Line 196: memory='1024MB',
Line 197: os=os,
cluster=engine_api.clusters.get('local_cluster'),
Line 198: template=engine_api.templates.get('Blank')
always add comma, go over all project
Line 199: )
Line 200: )
Line 201:
Line 202: # Create NIC
Line 231: engine_api.vms.get(
Line 232: 'local_vm'
Line 233: ).disks.add(
Line 234: engine_api.disks.get(
Line 235: alias='local_disk')
alignment... I think you can move the alias above, you have enough room, or fix
the ')'
Line 236: )
Line 237:
Line 238:
--
To view, visit http://gerrit.ovirt.org/17518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
