Alon Bar-Lev has posted comments on this change. Change subject: ovirt-live: migrate ovirt live plugin to otopi ......................................................................
Patch Set 7: (9 comments) .................................................... File fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py Line 54: stage=plugin.Stages.STAGE_INIT, Line 55: ) Line 56: def _init(self): Line 57: self.environment.setdefault( Line 58: oliveconst.OVIRTLIVEEnv.ENABLE, OVIRTLIVEEnv Line 59: True Line 60: ) Line 61: Line 62: @plugin.event( Line 84: oliveconst.Stages.OVIRTLIVE_CONFIG_STORAGE Line 85: ) Line 86: ) Line 87: def _initapi(self): Line 88: self.engine_api = self._ovirtsdk_api.API( _engine_api Line 89: url='https://{fqdn}:{port}/api'.format( Line 90: fqdn=self.environment[osetupcons.ConfigEnv.FQDN], Line 91: port=self.environment[osetupcons.ConfigEnv.PUBLIC_HTTPS_PORT], Line 92: ), Line 125: stage=plugin.Stages.CLOSEUP, Line 126: condition=lambda self: self._enabled, Line 127: name=oliveconst.Stages.OL_COPY_ISO, Line 128: before=( Line 129: oliveconst.Stages.OL_CREATE_VM, OL_ Line 130: ), Line 131: ) Line 132: def _copyiso(self): Line 133: self.logger.debug('Copying Iso Files') Line 138: ], Line 139: self.environment[ Line 140: osetupcons.ConfigEnv.ISO_DOMAIN_SD_UUID Line 141: ], Line 142: "images", osetupcons.ConfigEnv.ISO_DOMAIN_IMAGE_UID) format "images", osetup.... ) Line 143: for filename in fileList: Line 144: shutil.move(filename, targetPath) Line 145: os.chown( Line 146: os.path.join(targetPath, filename), Line 160: stage=plugin.Stages.CLOSEUP, Line 161: condition=lambda self: self._enabled, Line 162: name=oliveconst.Stages.OL_CREATE_VM, Line 163: after=( Line 164: oliveconst.Stages.OL_COPY_ISO, OL_ rename? Line 165: ), Line 166: ) Line 167: def _createvm(self): Line 168: # Defins OS param for the boot option Line 170: type_='unassigned', Line 171: boot=( Line 172: params.Boot(dev='cdrom'), Line 173: params.Boot(dev='hd'), Line 174: ) comma Line 175: ) Line 176: Line 177: # Create VM Line 178: self.engine_api.vms.add( Line 175: ) Line 176: Line 177: # Create VM Line 178: self.engine_api.vms.add( Line 179: params.VM( x= Line 180: name='local_vm', Line 181: memory='1024MB', Line 182: os=os, Line 183: cluster=engine_api.clusters.get('local_cluster'), Line 181: memory='1024MB', Line 182: os=os, Line 183: cluster=engine_api.clusters.get('local_cluster'), Line 184: template=engine_api.templates.get('Blank'), Line 185: ) , Line 186: ) Line 187: Line 188: # Create NIC Line 189: self.engine_api.vms.get( .................................................... File fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/oliveconst.py Line 64: @util.export Line 65: @util.codegen Line 66: class Const(object): Line 67: MINIMUM_SPACE_STORAGEDOMAIN_MB = 10240 Line 68: two spaces -- To view, visit http://gerrit.ovirt.org/17518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
