Sandro Bonazzola has posted comments on this change.

Change subject: packaging: Do not enable Gluster in Default cluster
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/appmode.py
Line 88:         ),
Line 89:         condition=lambda self: self._enabled,
Line 90:     )
Line 91:     def _misc(self):
Line 92:         VirtOnly = 1
please move constants at class level, uppercase.
Line 93:         GlusterOnly = 2
Line 94: 
Line 95:         mode = None
Line 96:         v = self.environment[osetupcons.ConfigEnv.APPLICATION_MODE]


-- 
To view, visit http://gerrit.ovirt.org/17552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b4d15689c730428aad09dd0c981faf5732731d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to