Aravinda VK has posted comments on this change.

Change subject: packaging: setup: Do not enable Gluster in Default cluster
......................................................................


Patch Set 5:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/appmode.py
Line 115:                 gluster=(mode == self.ApplicationMode.GlusterOnly),
Line 116:             ),
Line 117:         )
Line 118: 
Line 119:         if mode is not None:
This should be 
v != 'both'

If Application mode is both then the code should not update the default 
value(which is 255)
Line 120:             self.environment[osetupcons.DBEnv.STATEMENT].execute(
Line 121:                 statement="""
Line 122:                     select fn_db_update_config_value(
Line 123:                         'ApplicationMode',


-- 
To view, visit http://gerrit.ovirt.org/17552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b4d15689c730428aad09dd0c981faf5732731d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to