Daniel Erez has posted comments on this change.
Change subject: webadmin: add profiles instead of networks to vnic and vm
dialogs
......................................................................
Patch Set 22: Code-Review+2
(6 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
Line 69:
Line 70: @Template("<div style='width: 600px'><div style='width: 30%;
display: inline-block; border-right: 1px solid black; font-weight:bold;
padding-right: 25px; float: left'>{0}</div><div style='display: inline-block;
margin-left: 25px;'>{1}</div></div>")
Line 71: SafeHtml typeAheadNameDescription(String name, String description);
Line 72:
Line 73: @Template("{0} ({1})")
doesn't require a template, please move to messages
Line 74: SafeHtml profileAndNetwork(String profileName, String networkName);
Line 75:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/network/LogicalNetworkEditor.java
Line 38: new
ListModelTypeAheadListBoxEditor.NullSafeSuggestBoxRenderer<Object>() {
Line 39:
Line 40: @Override
Line 41: public String getReplacementStringNullSafe(Object
data) {
Line 42: return ((VnicProfileView) data).getName()
consider using a message
Line 43: + "/" //$NON-NLS-1$
Line 44: + ((VnicProfileView)
data).getNetworkName();
Line 45: }
Line 46:
Line 72:
profileEditor.setLabel(vnicInstanceType.getNetworkInterface().getName());
Line 73:
profileEditor.asEditor().getSubEditor().setValue((VnicProfileView)
vnicInstanceType.getSelectedItem());
Line 74: ((TakesConstrainedValueEditor)
profileEditor.asEditor().getSubEditor()).setAcceptableValues((Collection)
vnicInstanceType.getItems());
Line 75:
Line 76:
profileEditor.setElementId(ElementIdUtils.createElementId(elementId,
vnicInstanceType.getNetworkInterface()
formatter
Line 77: .getName()));
Line 78: }
Line 79:
Line 80: @Override
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
Line 173: new
ListModelTypeAheadListBoxEditor.NullSafeSuggestBoxRenderer<Object>() {
Line 174:
Line 175: @Override
Line 176: public String getReplacementStringNullSafe(Object
data) {
Line 177: return ((VnicProfileView) data).getName()
same
Line 178: + "/" //$NON-NLS-1$
Line 179: + ((VnicProfileView)
data).getNetworkName();
Line 180: }
Line 181:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditProfileBehavior.java
Line 19: profileList.setSelectedItem(null);
Line 20: return;
Line 21: }
Line 22:
Line 23: for (VnicProfileView vnicProfile : profiles)
formatter (curly braces...)
Line 24: {
Line 25: Guid profileId = vnicProfile == null ? null :
vnicProfile.getId();
Line 26: if (networkInterface.getVnicProfileId().equals(profileId))
Line 27: {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java
Line 55:
Line 56: private LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 57:
Line 58: @Override
Line 59: public int compare(VnicProfileView profile1,
VnicProfileView profile2) {
can be reused with the one in Linq?
Line 60: if (profile1 == null) {
Line 61: return profile2 == null ? 0 : 1;
Line 62: } else if (profile2 == null) {
Line 63: return -1;
--
To view, visit http://gerrit.ovirt.org/17322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00ea69609acf8a8bfeb0a5357489141f726b6323
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
