Lior Vernia has posted comments on this change.
Change subject: webadmin: add profiles instead of networks to vnic and vm
dialogs
......................................................................
Patch Set 19:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java
Line 38: if (returnValue == null) {
Line 39: return vnicProfiles;
Line 40: }
Line 41:
Line 42: for (VnicProfileView vnicProfile :
(ArrayList<VnicProfileView>) returnValue) {
Foreach should work with Iterable.
Line 43: Network network =
findNetworkById(vnicProfile.getNetworkId());
Line 44: if (network != null && network.isVmNetwork()) {
Line 45: vnicProfiles.add(vnicProfile);
Line 46: }
--
To view, visit http://gerrit.ovirt.org/17322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00ea69609acf8a8bfeb0a5357489141f726b6323
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
