Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: use ssh public key for allinone
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 86: 
Line 87:     @Override
Line 88:     public Response add(Host host) {
Line 89:         validateEnums(Host.class, host);
Line 90:         validateParameters(host, "name", "address");
this should be submitted in different patch and URGENT if required.
Line 91:         VdsStatic staticHost = getMapper(Host.class, 
VdsStatic.class).map(host, null);
Line 92:         staticHost.setVdsGroupId(getClusterId(host));
Line 93:         AddVdsActionParameters addParams = new 
AddVdsActionParameters(staticHost, host.getRootPassword());
Line 94:         if (host.isSetOverrideIptables()) {


-- 
To view, visit http://gerrit.ovirt.org/17996
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I885894bba4c998e5dd3e9b2fd4da61d833f7a3a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to