Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: use ssh public key for allinone ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py Line 96: ) Line 97: Line 98: already_in_file = False Line 99: content = [] Line 100: try: I am sorry! I did not see that this is in pki now... why not in all in one? you actually install backdoor to engine! Line 101: with open(authorized_keys_file, 'r') as f: Line 102: for line in f.read().splitlines(): Line 103: content.append(line) Line 104: if line == authorized_keys_line: -- To view, visit http://gerrit.ovirt.org/17996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I885894bba4c998e5dd3e9b2fd4da61d833f7a3a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
