Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: use ssh public key for allinone ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py Line 101: content.append(line) Line 102: if line == authorized_keys_line: Line 103: already_in_file = True Line 104: break Line 105: except: If the file does not exist/not readable, I just try to create it (below) in a file transaction. What exactly you want here? Check and Fail if exists and not readable? Line 106: pass Line 107: Line 108: if not already_in_file: Line 109: self.environment[ -- To view, visit http://gerrit.ovirt.org/17996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I885894bba4c998e5dd3e9b2fd4da61d833f7a3a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
