Omer Frenkel has posted comments on this change.
Change subject: engine: Speed up SPM re-selection process.
......................................................................
Patch Set 1:
(2 comments)
I agree this must be separated to refactor and code change, its hard to see the
changes
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 950: VDSReturnValue returnValue =
ResourceManager.getInstance().runVdsCommand(
Line 951: VDSCommandType.SpmStop,
Line 952: new SpmStopVDSCommandParameters(vdsId,
_storagePoolId)
Line 953: );
Line 954: return returnValue != null && (returnValue.getSucceeded()
|| isNotSPM(returnValue));
from the code it looks like when we get spmStatusError, the getSucceeded is
true, so i dont understand the change
Line 955: }
Line 956:
Line 957: private boolean isNotSPM(VDSReturnValue returnValue) {
Line 958: return returnValue != null && returnValue.getVdsError()
!= null &&
Line 955: }
Line 956:
Line 957: private boolean isNotSPM(VDSReturnValue returnValue) {
Line 958: return returnValue != null && returnValue.getVdsError()
!= null &&
Line 959: returnValue.getVdsError().getCode() ==
VdcBllErrors.SpmStatusError;
are you sure that every spmStatusError is the not spm result?
Line 960: }
Line 961:
Line 962: private SpmStatusResult startSpm(Guid vdsId,
Line 963: SpmStatusResult spmStatus,
--
To view, visit http://gerrit.ovirt.org/18013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c191ad8d4ec0fb4f5f8ff68b84fa5189ecc7114
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
