Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Speed up SPM re-selection process.
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
Line 32:
Line 33: if (isNotSPM(vdsReturnValue)) {
Line 34: performSpmStop = false;
Line 35: getVDSReturnValue().setSucceeded(true);
Line 36:
log.infoFormat("SpmStopVDSCommand::HSMGetAllTasksStatuses finished with 'No
SPM' status");
I think this log is redundant, according to the bug, this happens quite
frequently, and we already report on StopStopVdsCommand call, and this
additional print doesn't add anything that we would want to know.
Line 37: } else {
Line 38:
getVDSReturnValue().setSucceeded(vdsReturnValue.getSucceeded());
Line 39:
getVDSReturnValue().setVdsError(vdsReturnValue.getVdsError());
Line 40:
--
To view, visit http://gerrit.ovirt.org/18013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c191ad8d4ec0fb4f5f8ff68b84fa5189ecc7114
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
