Greg Sheremeta has uploaded a new change for review.

Change subject: webadmin: model setInfo cleanup
......................................................................

webadmin: model setInfo cleanup

Cleaned up several hard-coded non-internationalized strings that are
used to provide context help to the user -- moved them to
UIConstants file.

Changed all instances of setInfo() calls on models to
setChangeProhibitionReason().

Change-Id: I93e67e8b75da1a8409f1229a25bbe514c92bc867
Bug-Url: https://bugzilla.redhat.com/995754
Signed-off-by: Greg Sheremeta <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
11 files changed, 69 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/18197/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
index 7be3598..f9b26f3 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
@@ -399,29 +399,6 @@
         }
     }
 
-    private String privateinfo;
-
-    private String getinfo()
-    {
-        return privateinfo;
-    }
-
-    private void setinfo(String value)
-    {
-        privateinfo = value;
-    }
-
-    public String getInfo()
-    {
-        return getinfo();
-    }
-
-    public void setInfo(String value)
-    {
-        setinfo(value);
-        onPropertyChanged(new PropertyChangedEventArgs("Info")); //$NON-NLS-1$
-    }
-
     public Model()
     {
         setPropertyChangedEvent(new 
Event(ProvidePropertyChangedEvent.Definition));
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
index 841cec4..5e08d70 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
@@ -417,7 +417,8 @@
                         if (vdsList.size() > 0)
                         {
                             
clusterModel.getEnableTrustedService().setIsChangable(false);
-                            
clusterModel.getEnableTrustedService().setInfo(ConstantsManager.getInstance()
+                            
clusterModel.getEnableTrustedService().setChangeProhibitionReason(
+                                    ConstantsManager.getInstance()
                                     .getConstants()
                                     .trustedServiceDisabled());
                         }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
index e74544c..58cd948 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
@@ -51,6 +51,7 @@
 import org.ovirt.engine.ui.uicompat.NotifyCollectionChangedEventArgs;
 import org.ovirt.engine.ui.uicompat.ObservableCollection;
 import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
+import org.ovirt.engine.ui.uicompat.UIConstants;
 
 @SuppressWarnings("unused")
 public class DataCenterListModel extends ListWithDetailsModel implements 
ISupportSystemTreeContext
@@ -287,6 +288,7 @@
     public void edit()
     {
         StoragePool dataCenter = (StoragePool) getSelectedItem();
+        final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
 
         if (getWindow() != null)
         {
@@ -297,7 +299,7 @@
         setWindow(model);
         model.setEntity(dataCenter);
         model.setDataCenterId(dataCenter.getId());
-        
model.setTitle(ConstantsManager.getInstance().getConstants().editDataCenterTitle());
+        model.setTitle(constants.editDataCenterTitle());
         model.setHashName("edit_data_center"); //$NON-NLS-1$
         model.getName().setEntity(dataCenter.getName());
 
@@ -305,7 +307,7 @@
                 && getSystemTreeSelectedItem().getType() == 
SystemTreeItemType.DataCenter)
         {
             model.getName().setIsChangable(false);
-            model.getName().setInfo("Cannot edit Data Center's Name in tree 
context"); //$NON-NLS-1$
+            
model.getName().setChangeProhibitionReason(constants.cannotEditNameInTreeContext());
         }
 
         model.getDescription().setEntity(dataCenter.getdescription());
@@ -319,8 +321,8 @@
                         List<StorageDomain> storageDomainList = 
(List<StorageDomain>) returnValue;
 
                         if (storageDomainList.size() != 0) {
-                            model.getStorageTypeList()
-                                    .setChangeProhibitionReason("Cannot change 
Repository type with Storage Domains attached to it"); //$NON-NLS-1$
+                            
model.getStorageTypeList().setChangeProhibitionReason(
+                                    
constants.cannotChangeRepositoryTypeWithSDAttached());
                             model.getStorageTypeList().setIsChangable(false);
                         }
 
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
index 42c9103..41eb9e2 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
@@ -7,6 +7,8 @@
 import org.ovirt.engine.core.common.businessentities.VDSGroup;
 import org.ovirt.engine.core.common.businessentities.VDSStatus;
 import org.ovirt.engine.ui.uicommonweb.Linq;
+import org.ovirt.engine.ui.uicompat.ConstantsManager;
+import org.ovirt.engine.ui.uicompat.UIConstants;
 
 public class EditHostModel extends HostModel {
 
@@ -45,9 +47,10 @@
 
     @Override
     protected void setAllowChangeHostPlacementPropertiesWhenNotInMaintenance() 
{
-        getDataCenter().setChangeProhibitionReason("Data Center can be changed 
only when the Host is in Maintenance mode."); //$NON-NLS-1$
+        UIConstants constants = ConstantsManager.getInstance().getConstants();
+        
getDataCenter().setChangeProhibitionReason(constants.dcCanOnlyBeChangedWhenHostInMaintMode());
         getDataCenter().setIsChangable(false);
-        getCluster().setChangeProhibitionReason("Cluster can be changed only 
when the Host is in Maintenance mode."); //$NON-NLS-1$
+        
getCluster().setChangeProhibitionReason(constants.clusterCanOnlyBeChangedWhenHostInMaintMode());
         getCluster().setIsChangable(false);
     }
 
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
index 79cad93..046f3b5 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
@@ -625,6 +625,7 @@
                 HostListModel hostListModel = (HostListModel) model;
                 HostModel innerHostModel = (HostModel) 
hostListModel.getWindow();
                 ArrayList<StoragePool> dataCenters = (ArrayList<StoragePool>) 
result;
+                final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
 
                 if (hostListModel.getSystemTreeSelectedItem() != null)
                 {
@@ -632,7 +633,7 @@
                     {
                     case Host:
                         innerHostModel.getName().setIsChangable(false);
-                        innerHostModel.getName().setInfo("Cannot edit Host's 
Name in this tree context"); //$NON-NLS-1$
+                        
innerHostModel.getName().setChangeProhibitionReason(constants.cannotEditNameInTreeContext());
                         break;
                     case Hosts:
                     case Cluster:
@@ -649,11 +650,11 @@
                             }
                         }
                         innerHostModel.getDataCenter().setIsChangable(false);
-                        innerHostModel.getDataCenter().setInfo("Cannot choose 
Host's Data Center in tree context"); //$NON-NLS-1$
+                        
innerHostModel.getDataCenter().setChangeProhibitionReason(constants.cannotChangeDCInTreeContext());
                         
innerHostModel.getCluster().setItems(Arrays.asList(cluster));
                         innerHostModel.getCluster().setSelectedItem(cluster);
                         innerHostModel.getCluster().setIsChangable(false);
-                        innerHostModel.getCluster().setInfo("Cannot choose 
Host's Cluster in tree context"); //$NON-NLS-1$
+                        
innerHostModel.getCluster().setChangeProhibitionReason(constants.cannotChangeClusterInTreeContext());
                         break;
                     case DataCenter:
                         StoragePool selectDataCenter =
@@ -662,7 +663,7 @@
                                 .setItems(new 
ArrayList<StoragePool>(Arrays.asList(new StoragePool[] { selectDataCenter })));
                         
innerHostModel.getDataCenter().setSelectedItem(selectDataCenter);
                         innerHostModel.getDataCenter().setIsChangable(false);
-                        innerHostModel.getDataCenter().setInfo("Cannot choose 
Host's Data Center in tree context"); //$NON-NLS-1$
+                        
innerHostModel.getDataCenter().setChangeProhibitionReason(constants.cannotChangeDCInTreeContext());
                         break;
                     default:
                         innerHostModel.getDataCenter().setItems(dataCenters);
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
index f9de2a5..fc01b74 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
@@ -1104,13 +1104,11 @@
                 if (fingerprint != null && fingerprint.length() > 0)
                 {
                     getFetchSshFingerprint().setEntity(result);
-                    getFetchResult().setEntity((String)
-                            
ConstantsManager.getInstance().getConstants().successLoadingFingerprint());
+                    
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().successLoadingFingerprint());
                 }
                 else
                 {
-                    getFetchResult().setEntity((String)
-                             
ConstantsManager.getInstance().getConstants().errorLoadingFingerprint());
+                    
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().errorLoadingFingerprint());
                 }
             }
         };
@@ -1124,7 +1122,7 @@
                     + getHost().getInvalidityReasons().get(0));
         }
         else {
-            getFetchResult().setEntity((String) 
ConstantsManager.getInstance().getConstants().loadingFingerprint());
+            
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().loadingFingerprint());
             AsyncDataProvider.getHostFingerprint(aQuery, 
getHost().getEntity().toString());
         }
     }
@@ -1727,17 +1725,19 @@
         }
         else if (selectedSystemTreeItem != null)
         {
+            final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
+
             switch (selectedSystemTreeItem.getType())
             {
             case Host:
                 getName().setIsChangable(false);
-                getName().setInfo("Cannot edit Host's Name in this tree 
context"); //$NON-NLS-1$
+                
getName().setChangeProhibitionReason(constants.cannotEditNameInTreeContext());
                 break;
             case Hosts:
             case Cluster:
             case Cluster_Gluster:
                 getCluster().setIsChangable(false);
-                getCluster().setInfo("Cannot change Host's Cluster in tree 
context"); //$NON-NLS-1$
+                
getCluster().setChangeProhibitionReason(constants.cannotChangeClusterInTreeContext());
                 getDataCenter().setIsChangable(false);
                 break;
             case DataCenter:
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
index aa55540..b4b3ed6 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
@@ -42,6 +42,7 @@
 import org.ovirt.engine.ui.uicompat.ConstantsManager;
 import org.ovirt.engine.ui.uicompat.Event;
 import org.ovirt.engine.ui.uicompat.EventArgs;
+import org.ovirt.engine.ui.uicompat.UIConstants;
 
 public class StorageModel extends ListModel implements 
ISupportSystemTreeContext
 {
@@ -396,6 +397,8 @@
 
     private void initDataCenter()
     {
+        final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
+
         if (getSystemTreeSelectedItem() != null && 
getSystemTreeSelectedItem().getType() != SystemTreeItemType.System)
         {
             switch (getSystemTreeSelectedItem().getType())
@@ -411,7 +414,7 @@
                 getDataCenter().setItems(new 
ArrayList<StoragePool>(Arrays.asList(new StoragePool[] { dc })));
                 getDataCenter().setSelectedItem(dc);
                 getDataCenter().setIsChangable(false);
-                getDataCenter().setInfo("Cannot choose Storage's Data Center 
in tree context"); //$NON-NLS-1$
+                
getDataCenter().setChangeProhibitionReason(constants.cannotChangeDCInTreeContext());
             }
                 break;
 
@@ -419,7 +422,7 @@
                 VDS host = (VDS) getSystemTreeSelectedItem().getEntity();
 
                 getHost().setIsChangable(false);
-                getHost().setInfo("Cannot choose Storage's Host in tree 
context"); //$NON-NLS-1$
+                
getHost().setChangeProhibitionReason(constants.cannotChangeHostInTreeContext());
                 getHost().setSelectedItem(host);
 
                 SystemTreeItemModel dataCenterItem =
@@ -429,7 +432,7 @@
                 getDataCenter().setItems(new 
ArrayList<StoragePool>(Arrays.asList(new StoragePool[] { dc })));
                 getDataCenter().setSelectedItem(dc);
                 getDataCenter().setIsChangable(false);
-                getDataCenter().setInfo("Cannot choose Storage's Data Center 
in tree context"); //$NON-NLS-1$
+                
getDataCenter().setChangeProhibitionReason(constants.cannotChangeDCInTreeContext());
             }
                 break;
             }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
index 5f23166..2429b68 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
@@ -22,6 +22,8 @@
 import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider;
 import org.ovirt.engine.ui.uicommonweb.models.EntityModel;
 import org.ovirt.engine.ui.uicommonweb.models.SystemTreeItemModel;
+import org.ovirt.engine.ui.uicompat.ConstantsManager;
+import org.ovirt.engine.ui.uicompat.UIConstants;
 
 @SuppressWarnings("unused")
 public class ExistingVmModelBehavior extends VmModelBehaviorBase
@@ -209,8 +211,9 @@
 
         if (vm.isInitialized())
         {
-            getModel().getTimeZone()
-                    .setChangeProhibitionReason("Time Zone cannot be change 
since the Virtual Machine was booted at the first time."); //$NON-NLS-1$
+            UIConstants constants = 
ConstantsManager.getInstance().getConstants();
+            getModel().getTimeZone().setChangeProhibitionReason(
+                    constants.timeZoneCannotBeChangedAfterVMInit());
             getModel().getTimeZone().setIsChangable(false);
         }
 
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
index 26c0716..d252386 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
@@ -356,6 +356,7 @@
     protected void updateDefaultHost()
     {
         VDSGroup cluster = getModel().getSelectedCluster();
+        final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
 
         if (cluster == null)
         {
@@ -394,7 +395,7 @@
                                             .setItems(new 
ArrayList<VDS>(Arrays.asList(new VDS[] { vds })));
                                     
model.getDefaultHost().setSelectedItem(vds);
                                     
model.getDefaultHost().setIsChangable(false);
-                                    model.getDefaultHost().setInfo("Cannot 
choose other Host in tree context"); //$NON-NLS-1$
+                                    
model.getDefaultHost().setChangeProhibitionReason(constants.cannotChangeHostInTreeContext());
                                     break;
                                 }
                             }
@@ -554,7 +555,7 @@
             return;
         }
 
-        StoragePool dataCenter = (StoragePool) 
getModel().getSelectedDataCenter();
+        StoragePool dataCenter = getModel().getSelectedDataCenter();
         AsyncDataProvider.getPermittedStorageDomainsByStoragePoolId(new 
AsyncQuery(this, new INewAsyncCallback() {
             @Override
             public void onSuccess(Object target, Object returnValue) {
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
index 6166ecb..8267604 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
@@ -51,6 +51,7 @@
 import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback;
 import org.ovirt.engine.ui.uicompat.IFrontendMultipleActionAsyncCallback;
 import org.ovirt.engine.ui.uicompat.ObservableCollection;
+import org.ovirt.engine.ui.uicompat.UIConstants;
 
 public class VolumeListModel extends ListWithDetailsModel implements 
ISupportSystemTreeContext {
 
@@ -172,6 +173,7 @@
                 VolumeListModel volumeListModel = (VolumeListModel) model;
                 VolumeModel innerVolumeModel = (VolumeModel) 
volumeListModel.getWindow();
                 ArrayList<StoragePool> dataCenters = (ArrayList<StoragePool>) 
result;
+                final UIConstants constants = 
ConstantsManager.getInstance().getConstants();
 
                 if (volumeListModel.getSystemTreeSelectedItem() != null)
                 {
@@ -192,15 +194,13 @@
                             }
                         }
                         innerVolumeModel.getDataCenter().setIsChangable(false);
-                        
innerVolumeModel.getDataCenter().setInfo(ConstantsManager.getInstance()
-                                .getConstants()
-                                .cannotChooseVolumesDataCenterinTreeContect());
+                        
innerVolumeModel.getDataCenter().setChangeProhibitionReason(
+                                constants.cannotChangeDCInTreeContext());
                         
innerVolumeModel.getCluster().setItems(Arrays.asList(cluster));
                         innerVolumeModel.getCluster().setSelectedItem(cluster);
                         innerVolumeModel.getCluster().setIsChangable(false);
-                        
innerVolumeModel.getCluster().setInfo(ConstantsManager.getInstance()
-                                .getConstants()
-                                .cannotChooseVolumesClusterinTreeContect());
+                        
innerVolumeModel.getCluster().setChangeProhibitionReason(
+                                constants.cannotChangeClusterInTreeContext());
                         break;
                     case Clusters:
                     case DataCenter:
@@ -210,9 +210,8 @@
                                 .setItems(new 
ArrayList<StoragePool>(Arrays.asList(new StoragePool[] { selectDataCenter })));
                         
innerVolumeModel.getDataCenter().setSelectedItem(selectDataCenter);
                         innerVolumeModel.getDataCenter().setIsChangable(false);
-                        
innerVolumeModel.getDataCenter().setInfo(ConstantsManager.getInstance()
-                                .getConstants()
-                                .cannotChooseVolumesDataCenterinTreeContect());
+                        
innerVolumeModel.getDataCenter().setChangeProhibitionReason(
+                                constants.cannotChangeDCInTreeContext());
                         break;
                     default:
                         innerVolumeModel.getDataCenter().setItems(dataCenters);
diff --git 
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
 
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
index 621fcbd..19a134c 100644
--- 
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
+++ 
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
@@ -1594,12 +1594,6 @@
     @DefaultStringValue("Multiple bricks of a Replicate volume are present on 
the same server. This setup is not optimal. \nDo you still want to continue?")
     String addBricksToReplicateVolumeFromSameServerMsg();
 
-    @DefaultStringValue("Cannot choose Volume's Data Center in tree context")
-    String cannotChooseVolumesDataCenterinTreeContect();
-
-    @DefaultStringValue("Cannot choose Volume's Cluster in tree context")
-    String cannotChooseVolumesClusterinTreeContect();
-
     @DefaultStringValue("Disable Gluster Hooks")
     String confirmDisableGlusterHooks();
 
@@ -2049,5 +2043,27 @@
 
     @DefaultStringValue("Cannot edit name in tree context")
     String cannotEditNameInTreeContext();
+    
+    @DefaultStringValue("Cannot change Repository type with Storage Domains 
attached to it")
+    String cannotChangeRepositoryTypeWithSDAttached();
+    
+    @DefaultStringValue("Cannot change Data Center in tree context")
+    String cannotChangeDCInTreeContext();
+    
+    @DefaultStringValue("Cannot change Cluster in tree context")
+    String cannotChangeClusterInTreeContext();
+    
+    @DefaultStringValue("Cannot change Host in tree context")
+    String cannotChangeHostInTreeContext();
+    
+    @DefaultStringValue("Data Center can be changed only when the Host is in 
Maintenance mode.")
+    String dcCanOnlyBeChangedWhenHostInMaintMode();
+    
+    @DefaultStringValue("Cluster can be changed only when the Host is in 
Maintenance mode.")
+    String clusterCanOnlyBeChangedWhenHostInMaintMode();
+    
+    @DefaultStringValue("Time Zone cannot be changed after the Virtual Machine 
is initialized.")
+    String timeZoneCannotBeChangedAfterVMInit();
 
 }
+


-- 
To view, visit http://gerrit.ovirt.org/18197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I93e67e8b75da1a8409f1229a25bbe514c92bc867
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to