Daniel Erez has posted comments on this change.
Change subject: webadmin: model setInfo cleanup
......................................................................
Patch Set 2: Code-Review+1
(8 comments)
10X! (please extract the unrelated changes to a separate patch)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 1103: String fingerprint = (String) result;
Line 1104: if (fingerprint != null && fingerprint.length() > 0)
Line 1105: {
Line 1106: getFetchSshFingerprint().setEntity(result);
Line 1107:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().successLoadingFingerprint());
unrelated change
Line 1108: }
Line 1109: else
Line 1110: {
Line 1111:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().errorLoadingFingerprint());
Line 1107:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().successLoadingFingerprint());
Line 1108: }
Line 1109: else
Line 1110: {
Line 1111:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().errorLoadingFingerprint());
same
Line 1112: }
Line 1113: }
Line 1114: };
Line 1115:
Line 1121:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().fingerprintAddressError()
Line 1122: + getHost().getInvalidityReasons().get(0));
Line 1123: }
Line 1124: else {
Line 1125:
getFetchResult().setEntity(ConstantsManager.getInstance().getConstants().loadingFingerprint());
same
Line 1126: AsyncDataProvider.getHostFingerprint(aQuery,
getHost().getEntity().toString());
Line 1127: }
Line 1128: }
Line 1129:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 210: ));
Line 211:
Line 212: if (vm.isInitialized())
Line 213: {
Line 214: UIConstants constants =
ConstantsManager.getInstance().getConstants();
unrelated change - please extract to a separate patch
Line 215: getModel().getTimeZone().setChangeProhibitionReason(
Line 216: constants.timeZoneCannotBeChangedAfterVMInit());
Line 217: getModel().getTimeZone().setIsChangable(false);
Line 218: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 554: if (getModel().getDisks() == null) {
Line 555: return;
Line 556: }
Line 557:
Line 558: StoragePool dataCenter = getModel().getSelectedDataCenter();
unrelated change
Line 559:
AsyncDataProvider.getPermittedStorageDomainsByStoragePoolId(new
AsyncQuery(this, new INewAsyncCallback() {
Line 560: @Override
Line 561: public void onSuccess(Object target, Object returnValue) {
Line 562: VmModelBehaviorBase behavior = (VmModelBehaviorBase)
target;
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 2056: @DefaultStringValue("Cannot change Host in tree context")
Line 2057: String cannotChangeHostInTreeContext();
Line 2058:
Line 2059: @DefaultStringValue("Data Center can be changed only when the
Host is in Maintenance mode.")
Line 2060: String dcCanOnlyBeChangedWhenHostInMaintMode();
unrelated change - please extract to a separate patch
Line 2061:
Line 2062: @DefaultStringValue("Cluster can be changed only when the Host
is in Maintenance mode.")
Line 2063: String clusterCanOnlyBeChangedWhenHostInMaintMode();
Line 2064:
Line 2059: @DefaultStringValue("Data Center can be changed only when the
Host is in Maintenance mode.")
Line 2060: String dcCanOnlyBeChangedWhenHostInMaintMode();
Line 2061:
Line 2062: @DefaultStringValue("Cluster can be changed only when the Host
is in Maintenance mode.")
Line 2063: String clusterCanOnlyBeChangedWhenHostInMaintMode();
same
Line 2064:
Line 2065: @DefaultStringValue("Time Zone cannot be changed after the
Virtual Machine is initialized.")
Line 2066: String timeZoneCannotBeChangedAfterVMInit();
Line 2067:
Line 2062: @DefaultStringValue("Cluster can be changed only when the Host
is in Maintenance mode.")
Line 2063: String clusterCanOnlyBeChangedWhenHostInMaintMode();
Line 2064:
Line 2065: @DefaultStringValue("Time Zone cannot be changed after the
Virtual Machine is initialized.")
Line 2066: String timeZoneCannotBeChangedAfterVMInit();
same
Line 2067:
Line 2068: }
--
To view, visit http://gerrit.ovirt.org/18197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e67e8b75da1a8409f1229a25bbe514c92bc867
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
