Yair Zaslavsky has posted comments on this change. Change subject: frontend: node upgrade message improvement ......................................................................
Patch Set 3: (1 comment) .................................................... Commit Message Line 14: field it compares each segment delimited by dots and makes a comparison Line 15: between the node's OS and the ISO until it reaches a letter, Line 16: like "fc18" or "el6", which is derived from the rpm. Line 17: Line 18: oVirt Node - 2.6.0 - 20130212.0.fc18 20130212.0.fc18 Is this a valid string for host_os? Arent you repeating the 20130212.0.fc18 part? Line 19: oVirt Node - 2.6.0 - 20130212.fc18 Line 20: oVirt Node - 3.0.0 - 5.0.5.vdsm.fc19 Line 21: RHEV Hypervisor - 6.4 - 20130709.0.el6_4 Line 22: RHEV Hypervisor - 6.4 - 20130709.0.el6_4 -- To view, visit http://gerrit.ovirt.org/17987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
