Yair Zaslavsky has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Douglas, in general, would be great if you can provide unit test for this
functionality.
Maybe I did not completely understand your change, but I am troubled with my
findings about getRevision()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 681: alert = true;
Line 682: break;
Line 683: }
Line 684:
Line 685: if (Integer.toString(iso.getRevision()).length() >
release_host[0].length()) {
Can you specify in commit msg examples of ISOs (rpm versions) that you tried?
I'm afraid that iso.getRevision might return you 0 in several examples.
For example -
ovirt-node-iso-3.0.0-5.0.3.vdsm.fc19.iso
I checked the code of RpmVersion initialization, and looks like that
ovirt-node-iso-3.1.2-5.0.3.vdsm.fc19.iso
and
ovirt-node-iso-3.1.0-5.0.3.vdsm.fc19.iso
Return the same value of 0.
Line 686: alert = true;
Line 687: break;
Line 688: }
Line 689:
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
