Sahina Bose has posted comments on this change.
Change subject: gluster: Gluster volume rebalance status entities
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeRebalanceStatusDetails.java
Line 4: import java.util.List;
Line 5:
Line 6: import org.ovirt.engine.core.common.asynctasks.gluster.GlusterAsyncTask;
Line 7:
Line 8: public class GlusterVolumeRebalanceStatusDetails implements
Serializable {
Maybe you could rename this to GlusterVolumeTaskStatusDetails - so that it can
be reused for remove-brick status as well?
Line 9: private static final long serialVersionUID = -1134758927239004414L;
Line 10:
Line 11: private GlusterAsyncTask task;
Line 12: private List<GlusterVolumeRebalanceStatusForNode>
nodewiseStatusDetails;
Line 7:
Line 8: public class GlusterVolumeRebalanceStatusDetails implements
Serializable {
Line 9: private static final long serialVersionUID = -1134758927239004414L;
Line 10:
Line 11: private GlusterAsyncTask task;
I don't think you need the task reference here.
Line 12: private List<GlusterVolumeRebalanceStatusForNode>
nodewiseStatusDetails;
Line 13: private GlusterVolumeRebalanceStatusSummary statusSummary;
Line 14:
Line 15: public GlusterAsyncTask getTask() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeRebalanceStatusForNode.java
Line 10: private String nodeName;
Line 11: private int filesMoved;
Line 12: private long totalSizeMoved;
Line 13: private int filesScanned;
Line 14: private int filesFailed;
Please add skippedCount and runningTime too
Line 15: private GlusterTaskStatus status;
Line 16:
Line 17: public String getNodeName() {
Line 18: return nodeName;
--
To view, visit http://gerrit.ovirt.org/18297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c118790c57bf6d3ed0324a6f2a965783de2c57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
