Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Gluster volume rebalance status entities
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeRebalanceStatusDetails.java
Line 4: import java.util.List;
Line 5:
Line 6: import org.ovirt.engine.core.common.asynctasks.gluster.GlusterAsyncTask;
Line 7:
Line 8: public class GlusterVolumeRebalanceStatusDetails implements
Serializable {
Yes, will do that as the same details are there for remove-brick as well.
Line 9: private static final long serialVersionUID = -1134758927239004414L;
Line 10:
Line 11: private GlusterAsyncTask task;
Line 12: private List<GlusterVolumeRebalanceStatusForNode>
nodewiseStatusDetails;
Line 7:
Line 8: public class GlusterVolumeRebalanceStatusDetails implements
Serializable {
Line 9: private static final long serialVersionUID = -1134758927239004414L;
Line 10:
Line 11: private GlusterAsyncTask task;
Will remove the task field
Line 12: private List<GlusterVolumeRebalanceStatusForNode>
nodewiseStatusDetails;
Line 13: private GlusterVolumeRebalanceStatusSummary statusSummary;
Line 14:
Line 15: public GlusterAsyncTask getTask() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeRebalanceStatusForNode.java
Line 3: import java.io.Serializable;
Line 4:
Line 5: import
org.ovirt.engine.core.common.asynctasks.gluster.GlusterTaskStatus;
Line 6:
Line 7: public class GlusterVolumeRebalanceStatusForNode implements
Serializable {
Will try some generic name for the class and reuse
Line 8: private static final long serialVersionUID = -1134758927239004415L;
Line 9:
Line 10: private String nodeName;
Line 11: private int filesMoved;
Line 10: private String nodeName;
Line 11: private int filesMoved;
Line 12: private long totalSizeMoved;
Line 13: private int filesScanned;
Line 14: private int filesFailed;
Will add the fields engine side. VDSM changes would be required to incorporate
the same fields.
Line 15: private GlusterTaskStatus status;
Line 16:
Line 17: public String getNodeName() {
Line 18: return nodeName;
--
To view, visit http://gerrit.ovirt.org/18297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c118790c57bf6d3ed0324a6f2a965783de2c57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
