Alexander Wels has posted comments on this change.
Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Just a couple of minor white space issues, looks good otherwise.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml
Line 45:
Line 46: @external obrand_localeSelect;
Line 47: .obrand_localeSelect {
Line 48: }
Line 49:
Please remove the trailing white space here.
Line 50: @external obrand_headerLabelStyle;
Line 51: .obrand_headerLabelStyle {
Line 52: }
Line 53:
....................................................
File packaging/branding/ovirt.brand/common.css
Line 30: display: block;
Line 31: }
Line 32:
Line 33: .obrand_loginPopupHeader{
Line 34: position: absolute;
Can you change all the tab characters to spaces?
Line 35: top: 5px;
Line 36: right: 5px;
Line 37: left: 5px;
Line 38: }
--
To view, visit http://gerrit.ovirt.org/18156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80dcacf8d62f9bb051747e530f0d24e692388ce7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: 静 黎 <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: 静 黎 <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
