Alexander Wels has posted comments on this change.
Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml
Line 57: }
Line 58: </ui:style>
Line 59:
Line 60: <ui:style field='loginPopupStyle'>
Line 61: @external loginPopupView_loginPopupHeader;
if these are going to be part of the branding api, they should be prefixed with
obrand_
If not then we shouldn't have the @external
Line 62: .loginPopupView_loginPopupHeader {
Line 63: }
Line 64:
Line 65: @external obrand_loginPopupHeaderCenter;
Line 73: @external obrand_loginPopupHeaderImage;
Line 74: .obrand_loginPopupHeaderImage {
Line 75: }
Line 76:
Line 77: @external loginPopupView_headerLabelStyle;
if these are going to be part of the branding api, they should be prefixed with
obrand_
If not then we shouldn't have the @external
Line 78: .loginPopupView_headerLabelStyle {
Line 79: }
Line 80: </ui:style>
Line 81:
--
To view, visit http://gerrit.ovirt.org/18156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80dcacf8d62f9bb051747e530f0d24e692388ce7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: 静 黎 <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: 静 黎 <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
