Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: added favicon.ico to branding ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml Line 242: </servlet> Line 243: <servlet-mapping> Line 244: <servlet-name>BrandingServlet</servlet-name> Line 245: <url-pattern>/ovirt-engine-theme/*</url-pattern> Line 246: </servlet-mapping> this may be completely irrelevant / not important / not make any sense, but in [1], the above "url-pattern" has been changed from "theme" to "ovirt-engine-theme". Is there a chance that the below should, for some reason, follow the same naming pattern (i.e. "ovirt-engine-favicon.ico")? [1] http://gerrit.ovirt.org/#/c/17567/2/backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml Line 247: <servlet-mapping> Line 248: <servlet-name>BrandingServlet</servlet-name> Line 249: <url-pattern>/favicon.ico</url-pattern> Line 250: </servlet-mapping> -- To view, visit http://gerrit.ovirt.org/18385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dcd9d0f22a7c5867c39576020ad16dd6c53deda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
