Greg Sheremeta has posted comments on this change.

Change subject: userportal, webadmin: added favicon.ico to branding
......................................................................


Patch Set 1:

(1 comment)

....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 242:   </servlet>
Line 243:   <servlet-mapping>
Line 244:     <servlet-name>BrandingServlet</servlet-name>
Line 245:     <url-pattern>/ovirt-engine-theme/*</url-pattern>
Line 246:   </servlet-mapping>
Nope, not related :) the pattern below is basically a hardcode -- it says "any 
request that comes in for /favicon.ico, go straight to this servlet." It should 
never change :)
Line 247:   <servlet-mapping>
Line 248:     <servlet-name>BrandingServlet</servlet-name>
Line 249:     <url-pattern>/favicon.ico</url-pattern>
Line 250:   </servlet-mapping>


-- 
To view, visit http://gerrit.ovirt.org/18385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dcd9d0f22a7c5867c39576020ad16dd6c53deda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to