Yedidyah Bar David has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 2:
(2 comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 167:
Line 168: @plugin.event(
Line 169: stage=plugin.Stages.STAGE_MISC,
Line 170: condition=lambda self: self._enabled,
Line 171: priority=plugin.Stages.PRIORITY_FIRST,
Because files/simple removes files during misc.
I considered doing this at EARLY_MISC and decided not to - generally we do not
do changes before misc.
Line 172: )
Line 173: def _remove_services(self):
Line 174: #
Line 175: # avoid conflicts, disable iptables
Line 200: '--permanent',
Line 201: '--remove-service', service,
Line 202: ),
Line 203: )
Line 204: self.execute(
I don't have a specific reason, just seemed safer. Remove files, update daemon.
Line 205: (
Line 206: self.command.get('firewall-cmd'),
Line 207: '--reload'
Line 208: )
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
