Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 4:
(4 comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 50: def __init__(self, parent):
Line 51: self._parent = parent
Line 52:
Line 53: def __str__(self):
Line 54: return _("Firewalld Transaction")
quotes :)
Line 55:
Line 56: def prepare(self):
Line 57: pass
Line 58:
Line 57: pass
Line 58:
Line 59: def abort(self):
Line 60: for zone in self._zones:
Line 61: for service in self._disabled_services:
self._parent.environment?
Line 62: self.execute(
Line 63: (
Line 64: self.command.get('firewall-cmd'),
Line 65: '--zone', zone,
Line 64: self.command.get('firewall-cmd'),
Line 65: '--zone', zone,
Line 66: '--permanent',
Line 67: '--add-service', service,
Line 68: ),
you should ignore errors, just log them.
Line 69: )
Line 70:
Line 71: def commit(self):
Line 72: pass
Line 232: (
Line 233: self.command.get('firewall-cmd'),
Line 234: '--zone', zone,
Line 235: '--permanent',
Line 236: '--remove-service', service,
doesn't that fail if you do not have service in that zone?
Line 237: ),
Line 238: )
Line 239:
Line 240: @plugin.event(
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 4
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
