Yair Zaslavsky has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 7:
Douglas - the following unit test demonstrates that your last check should have
not produced an upgrade message -
@Test
public void testShouldAlertUpgrade() {
RpmVersion rpm = new
RpmVersion("ovirt-node-iso-2.6.1-20130212.fc18.iso", "ovirt-node-iso", true);
ArrayList<RpmVersion> rpmList = new ArrayList<RpmVersion>();
rpmList.add(rpm);
String[] hostOs = { "oVirt Node", "2.6.1", "20130212.fc18" };
assertFalse(shouldAlertUpgrade(rpmList, hostOs));
}
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
